[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROU
From: |
Thomas Huth |
Subject: |
Re: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment |
Date: |
Wed, 18 Dec 2019 20:32:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 18/12/2019 20.25, Philippe Mathieu-Daudé wrote:
> We don't need to explicit this obvious switch fall through.
> Stay consistent with the rest of the codebase.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: Peter Chubb <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Andrey Smirnov <address@hidden>
> Cc: address@hidden
> ---
> hw/pci-host/designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
> index 71e9b0d9b5..dd245516dd 100644
> --- a/hw/pci-host/designware.c
> +++ b/hw/pci-host/designware.c
> @@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32_t
> address, int len)
> break;
>
> case DESIGNWARE_PCIE_ATU_CR1:
> - case DESIGNWARE_PCIE_ATU_CR2: /* FALLTHROUGH */
> + case DESIGNWARE_PCIE_ATU_CR2:
> val = viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) /
> sizeof(uint32_t)];
> break;
>
Reviewed-by: Thomas Huth <address@hidden>