[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/8] hw/arm/xlnx-versal: Use memory_region_add_subregion() when p
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 3/8] hw/arm/xlnx-versal: Use memory_region_add_subregion() when priority is 0 |
Date: |
Sat, 14 Dec 2019 16:56:09 +0100 |
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
-memory_region_add_subregion_overlap(region, offset, subregion, 0)
+memory_region_add_subregion(region, offset, subregion)
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/arm/xlnx-versal-virt.c | 3 +--
hw/arm/xlnx-versal.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
index 462493c467..901e9ed86c 100644
--- a/hw/arm/xlnx-versal-virt.c
+++ b/hw/arm/xlnx-versal-virt.c
@@ -437,8 +437,7 @@ static void versal_virt_init(MachineState *machine)
/* Make the APU cpu address space visible to virtio and other
* modules unaware of muliple address-spaces. */
- memory_region_add_subregion_overlap(get_system_memory(),
- 0, &s->soc.fpd.apu.mr, 0);
+ memory_region_add_subregion(get_system_memory(), 0, &s->soc.fpd.apu.mr);
s->binfo.ram_size = machine->ram_size;
s->binfo.loader_start = 0x0;
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
index 8b3d8d85b8..538d907f8a 100644
--- a/hw/arm/xlnx-versal.c
+++ b/hw/arm/xlnx-versal.c
@@ -281,8 +281,8 @@ static void versal_realize(DeviceState *dev, Error **errp)
memory_region_init_ram(&s->lpd.mr_ocm, OBJECT(s), "ocm",
MM_OCM_SIZE, &error_fatal);
- memory_region_add_subregion_overlap(&s->mr_ps, MM_OCM, &s->lpd.mr_ocm, 0);
- memory_region_add_subregion_overlap(&s->fpd.apu.mr, 0, &s->mr_ps, 0);
+ memory_region_add_subregion(&s->mr_ps, MM_OCM, &s->lpd.mr_ocm);
+ memory_region_add_subregion(&s->fpd.apu.mr, 0, &s->mr_ps);
}
static void versal_init(Object *obj)
--
2.21.0
- [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 8/8] target/i386/cpu: Use 'mr' for MemoryRegion variables, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 1/8] hw/arm/nrf51_soc: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 3/8] hw/arm/xlnx-versal: Use memory_region_add_subregion() when priority is 0,
Philippe Mathieu-Daudé <=
- [PATCH 2/8] hw/arm/raspi: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 7/8] target/i386: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 6/8] hw/vfio/pci: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 5/8] hw/mips/boston: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 4/8] hw/i386/intel_iommu: Use memory_region_add_subregion when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Peter Maydell, 2019/12/14
- Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Michael S. Tsirkin, 2019/12/15