[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support
From: |
gengdongjiu |
Subject: |
Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support |
Date: |
Mon, 18 Nov 2019 21:57:12 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 2019/11/18 21:21, Michael S. Tsirkin wrote:
>> If use offset relative to GAS structure, the code does not easily extend to
>> support more Generic Hardware Error Source.
>> if use offset relative to hest_start, just use a loop, the code can support
>> more error source, for example:
>> for (source_id = 0; i<n; source_id++)
>> {
>> ......
>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id),
>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE,
>> source_id * sizeof(uint64_t));
>> .......
>> }
>>
>> My previous series patch support 2 error sources, but now only enable 'SEA'
>> type Error Source
> I'd try to merge this, worry about extending things later.
> This is at v21 and the simpler you can keep things,
> the faster it'll go in.
Thanks a lot for the comments. Yes, I think we can merge the v21 series.
- Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, (continued)
[RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Xiang Zheng, 2019/11/10
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Igor Mammedov, 2019/11/15
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, gengdongjiu, 2019/11/18
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, gengdongjiu, 2019/11/18
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Michael S. Tsirkin, 2019/11/18
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support,
gengdongjiu <=
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Igor Mammedov, 2019/11/25
- Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, gengdongjiu, 2019/11/27
Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Beata Michalska, 2019/11/22
Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support, Beata Michalska, 2019/11/22