Re: [RFC PATCH 14/14] hw/arm/raspi: Add the Raspberry Pi 4B board

[Peter Maydell]

On Tue, 8 Oct 2019 at 10:04, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Hi Esteban,
>
> On 9/29/19 5:53 PM, Esteban Bosse wrote:
> >> +static void raspi4_machine_init(MachineClass *mc)
> >> +{
> >> +    mc->desc = "Raspberry Pi 4B";
> >> +    mc->init = raspi4_init;
> >> +    mc->block_default_type = IF_SD;
> >> +    mc->no_parallel = 1;
> >> +    mc->no_floppy = 1;
> >> +    mc->no_cdrom = 1;
> >> +    mc->max_cpus = BCM283X_NCPUS;
> >> +    mc->min_cpus = BCM283X_NCPUS;
> >> +    mc->default_cpus = BCM283X_NCPUS;
> >> +    mc->default_ram_size = 1 * GiB;
> > The comercial models are: 1, 2 and 4 GiB. Why do you choose 1 GiB as
> > default?
>
> Well need one default, and 1GiB is the least beefy :)
> You can start a VM with more using the '-m' switch.

Among other things, a 2GB or more board will fail
'make check' on a 32-bit host, because 'make check' tries
to start all board models, and 32-bit hosts can only
handle up to 2047MB of guest RAM.

thanks
-- PMM