qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK


From: Peter Maydell
Subject: Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK
Date: Mon, 21 Oct 2019 11:05:03 +0100

On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau
<address@hidden> wrote:
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/dma/sparc32_dma.c | 2 +-
>  hw/net/lance.c       | 5 ++---
>  hw/net/pcnet-pci.c   | 2 +-
>  hw/net/pcnet.h       | 2 +-
>  4 files changed, 5 insertions(+), 6 deletions(-)

I feel like there's probably a way to be more type-safe here
(eg for the lance.c property we know the linked device must
be TYPE_SPARC32_LEDMA_DEVICE, not just TYPE_DEVICE), but I guess
this will do.

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]