[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage |
|
Date: |
Fri, 18 Oct 2019 17:34:30 +0100 |
On Fri, 18 Oct 2019 at 17:11, Marc-André Lureau
<address@hidden> wrote:
> Is there really much difference between:
>
> dev = qdev_create()
> qdev_prop_set_ptr(dev, "prop", ptr);
> qdev_init_nofail()
>
> and
>
> dev = qdev_create(MYDEV)
> MYDEV(dev)->prop = ptr;
> qdev_init_nofail()
One is easier to grep for than the other if you're
looking for things we need to fix :-)
I've just replied to patch 1 of this set with a reply that
gives my general objections which are the same for this patch
as that one; it's probably less confusing if we keep the
conversation in that thread rather than conducting it along
two parallel tracks (my fault for not reading the whole
series first; I should probably have replied to the cover
letter).
thanks
-- PMM
- Re: [PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK, (continued)
[PATCH 02/14] vmmouse: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
[PATCH 03/14] lance: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
[PATCH 04/14] etraxfs: remove PROP_PTR usage, Marc-André Lureau, 2019/10/18
Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage, Peter Maydell, 2019/10/21
[PATCH 05/14] dp8393x: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
[PATCH 06/14] leon3: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
[PATCH 07/14] RFC: mips/cps: fix setting saar property, Marc-André Lureau, 2019/10/18
[PATCH 08/14] cris: replace PROP_PTR with PROP_LINK for interrupt vector, Marc-André Lureau, 2019/10/18