[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds te
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch |
Date: |
Tue, 17 Sep 2019 12:46:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/17/19 2:41 PM, Alex Bennée wrote:
> + /* From https://bugs.launchpad.net/qemu/+bug/1841491 */
> + add_f32_const(0x1.ffffffffffffcp-1022);
> + add_f32_const(0x1.0000000000001p-1);
> + add_f32_const(0x0.0000000000001p-1022);
These three constants do not fit in float32.
> + add_f32_const(0x8p-152);
> + add_f32_const(0x8p-152);
> + add_f32_const(0x8p-152);
Why are you adding 3 of the same?
> + for (j = 0; j < nums; j++) {
> + for (k = 0; k < 3; k++) {
> + a = get_f32(j + ((k)%3));
> + b = get_f32(j + ((k+1)%3));
> + c = get_f32(j + ((k+2)%3));
How does this not overflow nums?
There does not appear to be an assert on overflow in get_f<N>.
> +#if defined(__arm__)
> + r = __builtin_fmaf(a, b, c);
> +#else
> + r = __builtin_fmaf(a, b, c);
> +#endif
Eh?
> +/* Number of constants in each table */
> +int get_num_f16();
> +int get_num_f32();
> +int get_num_f64();
This is not c++; you want (void) to indicate no arguments.
r~
- [Qemu-arm] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build, (continued)
- [Qemu-arm] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build, Alex Bennée, 2019/09/17
- [Qemu-arm] [PATCH v1 4/9] target/ppc: fix signal delivery for ppc64abi32, Alex Bennée, 2019/09/17
- [Qemu-arm] [PATCH v1 5/9] tests/tcg: clean-up some comments after the de-tangling, Alex Bennée, 2019/09/17
- [Qemu-arm] [PATCH v1 6/9] tests/tcg: re-enable linux-test for ppc64abi32, Alex Bennée, 2019/09/17
- [Qemu-arm] [PATCH v1 8/9] tests/tcg: add generic version of float_convs, Alex Bennée, 2019/09/17
- [Qemu-arm] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch, Alex Bennée, 2019/09/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch,
Richard Henderson <=
[Qemu-arm] [PATCH v1 9/9] tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS), Alex Bennée, 2019/09/17
Re: [Qemu-arm] [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float), no-reply, 2019/09/18