[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v6 5/6] target/arm: remove run-time semihosting checks
From: |
Alex Bennée |
Subject: |
[Qemu-arm] [PATCH v6 5/6] target/arm: remove run-time semihosting checks for linux-user |
Date: |
Fri, 13 Sep 2019 16:18:44 +0100 |
Now we do all our checking at translate time we can make cpu_loop a
little bit simpler. We also introduce a simple linux-user semihosting
test case to defend the functionality. The out-of-tree softmmu based
semihosting tests are still more comprehensive.
Signed-off-by: Alex Bennée <address@hidden>
---
linux-user/arm/cpu_loop.c | 3 ---
linux-user/arm/target_syscall.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c
index 8d65de5b9f4..e28c45cd4ab 100644
--- a/linux-user/arm/cpu_loop.c
+++ b/linux-user/arm/cpu_loop.c
@@ -325,9 +325,6 @@ void cpu_loop(CPUARMState *env)
if (n == ARM_NR_cacheflush) {
/* nop */
- } else if (n == ARM_NR_semihosting
- || n == ARM_NR_thumb_semihosting) {
- env->regs[0] = do_arm_semihosting (env);
} else if (n == 0 || n >= ARM_SYSCALL_BASE || env->thumb) {
/* linux syscall */
if (env->thumb || n == 0) {
diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h
index afc0772e194..f85cbdaf56f 100644
--- a/linux-user/arm/target_syscall.h
+++ b/linux-user/arm/target_syscall.h
@@ -18,9 +18,6 @@ struct target_pt_regs {
#define ARM_NR_set_tls (ARM_NR_BASE + 5)
#define ARM_NR_get_tls (ARM_NR_BASE + 6)
-#define ARM_NR_semihosting 0x123456
-#define ARM_NR_thumb_semihosting 0xAB
-
#if defined(TARGET_WORDS_BIGENDIAN)
#define UNAME_MACHINE "armv5teb"
#else
--
2.20.1
- [Qemu-arm] [PATCH v6 0/6] semihosting cleanups (plus minor tests/tcg tweak), Alex Bennée, 2019/09/13
- [Qemu-arm] [PATCH v6 1/6] tests/tcg: clean-up some comments after the de-tangling, Alex Bennée, 2019/09/13
- [Qemu-arm] [PATCH v6 2/6] target/arm: handle M-profile semihosting at translate time, Alex Bennée, 2019/09/13
- [Qemu-arm] [PATCH v6 3/6] target/arm: handle A-profile semihosting at translate time, Alex Bennée, 2019/09/13
- [Qemu-arm] [PATCH v6 5/6] target/arm: remove run-time semihosting checks for linux-user,
Alex Bennée <=
- [Qemu-arm] [PATCH v6 4/6] target/arm: remove run time semihosting checks, Alex Bennée, 2019/09/13
- [Qemu-arm] [PATCH v6 6/6] tests/tcg: add linux-user semihosting smoke test for ARM, Alex Bennée, 2019/09/13
- Re: [Qemu-arm] [PATCH v6 0/6] semihosting cleanups (plus minor tests/tcg tweak), Peter Maydell, 2019/09/17