[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables fo
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board |
Date: |
Wed, 11 Sep 2019 13:57:06 +0100 |
On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum
<address@hidden> wrote:
>
> This patch is in preparation for adding numamem and memhp tests
> to arm/virt board so that 'make check' is happy. This may not
> be required once the scripts are run and new tables are
> generated with ".numamem" and ".memhp" extensions.
>
> Signed-off-by: Shameer Kolothum <address@hidden>
> ---
> I am not sure this is the right way to do this. But without this, when
> the numamem and memhp tests are added, you will get,
>
> Looking for expected file 'tests/data/acpi/virt/SRAT.numamem'
> Looking for expected file 'tests/data/acpi/virt/SRAT'
> **
> ERROR:tests/bios-tables-test.c:327:load_expected_aml: assertion failed:
> (exp_sdt.aml_file)
>
> ---
> tests/data/acpi/virt/SLIT | Bin 0 -> 48 bytes
> tests/data/acpi/virt/SRAT | Bin 0 -> 224 bytes
> 2 files changed, 0 insertions(+), 0 deletions(-)
> create mode 100644 tests/data/acpi/virt/SLIT
> create mode 100644 tests/data/acpi/virt/SRAT
Do the tests pass with this patch and without the
patch that adds the tests? (That is, can we keep the
two patches separate without breaking bisection, or
do we need to squash them together?)
I'll leave it to somebody who understands the ACPI
tests stuff to answer whether there's a better way to
do this.
thanks
-- PMM
- Re: [Qemu-arm] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot, (continued)
[Qemu-arm] [PATCH-for-4.2 v10 07/11] hw/arm: Factor out powerdown notifier from GPIO, Shameer Kolothum, 2019/09/04
[Qemu-arm] [PATCH-for-4.2 v10 08/11] hw/arm: Use GED for system_powerdown event, Shameer Kolothum, 2019/09/04
[Qemu-arm] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation, Shameer Kolothum, 2019/09/04
[Qemu-arm] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Shameer Kolothum, 2019/09/04
- Re: [Qemu-arm] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board,
Peter Maydell <=
- Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Igor Mammedov, 2019/09/11
- Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Michael S. Tsirkin, 2019/09/11
- Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Shameerali Kolothum Thodi, 2019/09/11
- Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Michael S. Tsirkin, 2019/09/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board, Peter Maydell, 2019/09/17
[Qemu-arm] [PATCH-for-4.2 v10 11/11] tests: Add bios tests to arm/virt, Shameer Kolothum, 2019/09/04