[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 2/4] target/arm: handle A-profile semihosting a
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH v3 2/4] target/arm: handle A-profile semihosting at translate time |
|
Date: |
Fri, 6 Sep 2019 14:33:41 +0100 |
On Fri, 6 Sep 2019 at 14:16, Alex Bennée <address@hidden> wrote:
>
>
> Peter Maydell <address@hidden> writes:
>
> > On Fri, 6 Sep 2019 at 13:47, Alex Bennée <address@hidden> wrote:
>
> >
> > Doesn't this accidentally enable semihosting via SVC for
> > M-profile ?
>
> We must have done that before then.
No, we didn't do it before, because we were handling it in
arm_cpu_do_interrupt(), which is A/R-profile only. The
M-profile code goes via arm_v7m_cpu_do_interrupt() which doesn't
check for semihosting when it sees an EXCP_SWI.
> Just gate it with && !arm_dc_feature(s, ARM_FEATURE_M) then?
Yes, I think that's the right fix.
thanks
-- PMM