[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v4 0/3] Add Aspeed GPIO controller model
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH v4 0/3] Add Aspeed GPIO controller model |
Date: |
Fri, 16 Aug 2019 18:21:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 16/08/2019 09:32, Rashmica Gupta wrote:
> v5:
> - integrated AspeedGPIOController fields into AspeedGPIOClass
> - separated ast2600_3_6v and ast2600_1_8v into two classes
Rashmica,
This looks much nicer !
Please take a look at branch aspeed-4.2 in which I have merged your
v5 and modified slightly the ast2600 part.
https://github.com/legoater/qemu/commit/02b3df3f1a380eec4df7c49e88fa7ba27f75a610
I introduced a gpio_1_8v controller with its specific MMIO and IRQ
definitions. Tell me what you think of it. The principal motivation
behind these adjustments is that I don't know yet how we are going
to instantiate/realize the specific models of the AST2600 SoC. the
GPIO 1.8v is one of these extra controllers.
Thanks,
C.
> v4:
> - proper interupt handling thanks to Andrew
> - switch statements for reading and writing suggested by Peter
> - some small cleanups suggested by Alexey
>
> v3:
> - didn't have each gpio set up as an irq
> - now can't access set AC on ast2400 (only exists on ast2500)
> - added ast2600 implementation (patch 3)
> - renamed a couple of variables for clarity
>
> v2: Addressed Andrew's feedback, added debounce regs, renamed get/set to
> read/write to minimise confusion with a 'set' of registers.
>
> Rashmica Gupta (3):
> hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500
> aspeed: add a GPIO controller to the SoC
> hw/gpio: Add in AST2600 specific implementation
>
> include/hw/arm/aspeed_soc.h | 3 +
> include/hw/gpio/aspeed_gpio.h | 100 ++++
> hw/arm/aspeed_soc.c | 17 +
> hw/gpio/aspeed_gpio.c | 1006 +++++++++++++++++++++++++++++++++
> hw/gpio/Makefile.objs | 1 +
> 5 files changed, 1127 insertions(+)
> create mode 100644 include/hw/gpio/aspeed_gpio.h
> create mode 100644 hw/gpio/aspeed_gpio.c
>
- Re: [Qemu-arm] [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model, (continued)