[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 7/8] hw/misc: Add a config switch for the "unim
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-arm] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device |
|
Date: |
Wed, 31 Jul 2019 17:55:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/31/19 1:50 PM, Thomas Huth wrote:
> On 31/07/2019 13.47, Philippe Mathieu-Daudé wrote:
>> On 7/31/19 9:56 AM, Thomas Huth wrote:
>>> The device is only used by some few boards. Let's use a proper Kconfig
>>> switch so that we only compile this code if we really need it.
>>
>> I'd prefer having the UnimpDevice user-creatable and always present as a
>> core device...
>
> Why? This is a sysbus device that needs to be wired up in code, so I
> don't see a reason for making this user-creatable right now.
Right now no.
> Anyway, that's a different subject, so this should not be part of this
> patch.
Fair enough.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-arm] [PATCH v2 4/8] hw/core: Add a config switch for the "register" device, (continued)
[Qemu-arm] [PATCH v2 8/8] hw/core: Add a config switch for the generic loader device, Thomas Huth, 2019/07/31