[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 02/67] target/arm: Remove offset argument to gen_e

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 02/67] target/arm: Remove offset argument to gen_exception_insn
Date: Mon, 29 Jul 2019 14:48:58 +0100

On Fri, 26 Jul 2019 at 18:50, Richard Henderson
<address@hidden> wrote:
> The address of the current insn is still available in s->base.pc_next.
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate-vfp.inc.c |  6 +++---
>  target/arm/translate.c         | 32 ++++++++++++++++----------------
>  2 files changed, 19 insertions(+), 19 deletions(-)

This works because all our uses of gen_exception_insn() are
for generating an exception at the PC of the current insn;
things like SVC/SMC/HVC which want to generate an exception
where the PC is that of the following insn are already handled
via a different function.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]