[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 3/5] pci: designware: Update MSI mapping unconditi

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally
Date: Mon, 1 Jul 2019 12:56:04 +0100

On Tue, 16 Apr 2019 at 02:39, Andrey Smirnov <address@hidden> wrote:
> Expression to calculate update_msi_mapping in code handling writes to
> DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should
> be:
>     !!root->msi.intr[0].enable ^ !!val;
> so that MSI mapping is updated when enabled transitions from either
> "none" -> "any" or "any" -> "none". Since that register shouldn't be
> written to very often, change the code to update MSI mapping
> unconditionally instead of trying to fix the update_msi_mapping logic.
> Signed-off-by: Andrey Smirnov <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> ---

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]