[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/6] memory: Remove unused memory_
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/6] memory: Remove unused memory_region_iommu_replay_all() |
Date: |
Mon, 1 Jul 2019 11:58:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/1/19 11:30 AM, Eric Auger wrote:
> memory_region_iommu_replay_all is not used. Remove it.
>
> Signed-off-by: Eric Auger <address@hidden>
> Reported-by: Peter Maydell <address@hidden>
> ---
> include/exec/memory.h | 10 ----------
> memory.c | 9 ---------
> 2 files changed, 19 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index e6140e8a04..bdd76653a8 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -1076,16 +1076,6 @@ void
> memory_region_register_iommu_notifier(MemoryRegion *mr,
> */
> void memory_region_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier
> *n);
>
> -/**
> - * memory_region_iommu_replay_all: replay existing IOMMU translations
> - * to all the notifiers registered.
> - *
> - * Note: this is not related to record-and-replay functionality.
> - *
> - * @iommu_mr: the memory region to observe
> - */
> -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr);
> -
> /**
> * memory_region_unregister_iommu_notifier: unregister a notifier for
> * changes to IOMMU translation entries.
> diff --git a/memory.c b/memory.c
> index 0a089a73ae..290a1493ef 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1910,15 +1910,6 @@ void memory_region_iommu_replay(IOMMUMemoryRegion
> *iommu_mr, IOMMUNotifier *n)
> }
> }
>
> -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr)
> -{
> - IOMMUNotifier *notifier;
> -
> - IOMMU_NOTIFIER_FOREACH(notifier, iommu_mr) {
> - memory_region_iommu_replay(iommu_mr, notifier);
> - }
> -}
> -
> void memory_region_unregister_iommu_notifier(MemoryRegion *mr,
> IOMMUNotifier *n)
> {
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- Re: [Qemu-arm] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case, (continued)
[Qemu-arm] [PATCH v2 5/6] hw/arm/smmuv3: Log a guest error when decoding an invalid STE, Eric Auger, 2019/07/01
[Qemu-arm] [PATCH v2 2/6] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute, Eric Auger, 2019/07/01
[Qemu-arm] [PATCH v2 1/6] memory: Remove unused memory_region_iommu_replay_all(), Eric Auger, 2019/07/01
[Qemu-arm] [PATCH v2 4/6] hw/arm/smmuv3: Advertise VFIO_NESTED, Eric Auger, 2019/07/01
[Qemu-arm] [PATCH v2 6/6] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations, Eric Auger, 2019/07/01