[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 11/21] aspeed/timer: Ensure positive muldiv del

From: Joel Stanley
Subject: Re: [Qemu-arm] [PATCH v2 11/21] aspeed/timer: Ensure positive muldiv delta
Date: Wed, 19 Jun 2019 02:15:54 +0000

On Tue, 18 Jun 2019 at 16:54, Cédric Le Goater <address@hidden> wrote:
> From: Christian Svensson <address@hidden>
> If the host decrements the counter register that results in a negative
> delta. This is then passed to muldiv64 which only handles unsigned
> numbers resulting in bogus results.
> This fix ensures the delta being operated on is positive.
> Test case: kexec a kernel using aspeed_timer and it will freeze on the
> second bootup when the kernel initializes the timer. With this patch
> that no longer happens and the timer appears to run OK.
> Signed-off-by: Christian Svensson <address@hidden>
> Signed-off-by: Cédric Le Goater <address@hidden>

Reviewed-by: Joel Stanley <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]