Re: [Qemu-arm] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree

[Richard Henderson]

On 6/6/19 12:46 PM, Peter Maydell wrote:
> +    vd = tcg_temp_new_i32();
> +    vm = tcg_temp_new_i32();
> +
> +    neon_load_reg32(vd, a->vd);
> +    if (a->z) {
> +        tcg_gen_movi_i32(vm, 0);
> +    } else {
> +        neon_load_reg32(vm, a->vm);
> +    }
> +
> +    if (a->e) {
> +        gen_helper_vfp_cmpes(vd, vm, cpu_env);
> +    } else {
> +        gen_helper_vfp_cmps(vd, vm, cpu_env);
> +    }
> +    return true;

Missing the temp frees, again in the dp version.  Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~