[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v2 04/28] semihosting: enable chardev

From: Alex Bennée
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2 04/28] semihosting: enable chardev backed output for console
Date: Tue, 28 May 2019 10:36:44 +0100
User-agent: mu4e 1.3.2; emacs 26.1

Richard Henderson <address@hidden> writes:

> On 5/23/19 6:25 AM, Alex Bennée wrote:
>>  int qemu_semihosting_log_out(const char *s, int len)
>>  {
>> -    return write(STDERR_FILENO, s, len);
>> +    Chardev *chardev = semihosting_get_chardev();
>> +    if (chardev) {
>> +        return qemu_chr_write_all(chardev, (uint8_t *) s, len);
>> +    } else {
>> +        return write(STDERR_FILENO, s, len);
>> +    }
>>  }
> Can we not create a default chardev that outputs to stderr, so that the
> conditional is not required?  Or does that somehow interfere with how this
> connects up for linux-user/?

The one linux-user case does it's own thing which uses the same API but
has a dumb implementation without a chardev. I'm unsure how you go about
creating a plain chardev backend programatically although I'll probably
want to do that for the plugins as well so I'll look into it.

I'll merge this as is for now though.

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]