[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/4] hw/arm/exynos4: Remove unuseful
From: |
Alistair Francis |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code |
Date: |
Mon, 20 May 2019 14:47:20 -0700 |
On Mon, May 20, 2019 at 2:45 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/arm/exynos4_boards.c | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
> index ea8100f65a8..f0c24b7992e 100644
> --- a/hw/arm/exynos4_boards.c
> +++ b/hw/arm/exynos4_boards.c
> @@ -35,20 +35,6 @@
> #include "hw/net/lan9118.h"
> #include "hw/boards.h"
>
> -#undef DEBUG
> -
> -//#define DEBUG
> -
> -#ifdef DEBUG
> - #undef PRINT_DEBUG
> - #define PRINT_DEBUG(fmt, args...) \
> - do { \
> - fprintf(stderr, " [%s:%d] "fmt, __func__, __LINE__, ##args); \
> - } while (0)
> -#else
> - #define PRINT_DEBUG(fmt, args...) do {} while (0)
> -#endif
> -
> #define SMDK_LAN9118_BASE_ADDR 0x05000000
>
> typedef enum Exynos4BoardType {
> @@ -140,16 +126,6 @@ exynos4_boards_init_common(MachineState *machine,
> exynos4_board_binfo.gic_cpu_if_addr =
> EXYNOS4210_SMP_PRIVATE_BASE_ADDR + 0x100;
>
> - PRINT_DEBUG("\n ram_size: %luMiB [0x%08lx]\n"
> - " kernel_filename: %s\n"
> - " kernel_cmdline: %s\n"
> - " initrd_filename: %s\n",
> - exynos4_board_ram_size[board_type] / 1048576,
> - exynos4_board_ram_size[board_type],
> - machine->kernel_filename,
> - machine->kernel_cmdline,
> - machine->initrd_filename);
> -
> exynos4_boards_init_ram(s, get_system_memory(),
> exynos4_board_ram_size[board_type]);
>
> --
> 2.20.1
>
>
- [Qemu-arm] [PATCH 0/4] arm: exynos4: Add dma support for smdkc210, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code,
Alistair Francis <=
- [Qemu-arm] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 3/4] hw/arm/exynos4210: Add DMA support for the Exynos4210, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 4/4] hw/arm/exynos4210: QOM'ify the Exynos4210 SoC, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [PATCH 0/4] arm: exynos4: Add dma support for smdkc210, Peter Maydell, 2019/05/23