[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map |
Date: |
Mon, 13 May 2019 17:37:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Andrew Jones <address@hidden> writes:
> Allow the host cpu type to enable SVE in guests with the sve-vls-map
> cpu property.
>
> Signed-off-by: Andrew Jones <address@hidden>
> ---
> target/arm/cpu.c | 1 +
> target/arm/cpu.h | 2 ++
> target/arm/cpu64.c | 12 +++++++++---
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index ea0e24bba8b6..a5c01ff42c78 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -2222,6 +2222,7 @@ static void arm_host_initfn(Object *obj)
> ARMCPU *cpu = ARM_CPU(obj);
>
> kvm_arm_set_cpu_features_from_host(cpu);
> + aarch64_add_sve_vls_map_property(obj);
> arm_cpu_post_init(obj);
> }
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index f0d0ce759ba8..13731ccb39f3 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -976,11 +976,13 @@ int aarch64_cpu_gdb_write_register(CPUState *cpu,
> uint8_t *buf, int reg);
> void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq);
> void aarch64_sve_change_el(CPUARMState *env, int old_el,
> int new_el, bool el0_a64);
> +void aarch64_add_sve_vls_map_property(Object *obj);
> #else
> static inline void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq) { }
> static inline void aarch64_sve_change_el(CPUARMState *env, int o,
> int n, bool a)
> { }
> +void aarch64_add_sve_vls_map_property(Object *obj) { }
qemu/target/arm/cpu.h:985:6: error: no previous prototype for
‘aarch64_add_sve_vls_map_property’ [-Werror=missing-prototypes]
void aarch64_add_sve_vls_map_property(Object *obj) { }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Did you forget static inline?
> #endif
>
> target_ulong do_arm_semihosting(CPUARMState *env);
[...]
- [Qemu-arm] [PATCH 00/13] target/arm/kvm: enable SVE in guests, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 01/13] target/arm/kvm64: fix error returns, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 10/13] target/arm/monitor: kvm: only return valid sve vector sets, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 02/13] update-linux-headers: Add sve_context.h to asm-arm64, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 09/13] target/arm/kvm: Export kvm_arm_get_sve_vls, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map, Andrew Jones, 2019/05/12
- Re: [Qemu-arm] [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map,
Markus Armbruster <=
- [Qemu-arm] [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 04/13] target/arm/kvm: Move the get/put of fpsimd registers out, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 06/13] target/arm/kvm: max cpu: Enable SVE when available, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 12/13] target/arm/kvm: max cpu: Add support for sve-vls-map, Andrew Jones, 2019/05/12
- [Qemu-arm] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve, Andrew Jones, 2019/05/12