[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PULL 1/8] qxl: check release info object
From: |
Gerd Hoffmann |
Subject: |
[Qemu-arm] [PULL 1/8] qxl: check release info object |
Date: |
Tue, 7 May 2019 10:19:39 +0200 |
From: Prasad J Pandit <address@hidden>
When releasing spice resources in release_resource() routine,
if release info object 'ext.info' is null, it leads to null
pointer dereference. Add check to avoid it.
Reported-by: Bugs SysSec <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/display/qxl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index c8ce5781e037..632923add239 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -777,6 +777,9 @@ static void interface_release_resource(QXLInstance *sin,
QXLReleaseRing *ring;
uint64_t *item, id;
+ if (!ext.info) {
+ return;
+ }
if (ext.group_id == MEMSLOT_GROUP_HOST) {
/* host group -> vga mode update request */
QXLCommandExt *cmdext = (void *)(intptr_t)(ext.info->id);
--
2.18.1
- [Qemu-arm] [PULL 0/8] Vga 20190507 patches, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 1/8] qxl: check release info object,
Gerd Hoffmann <=
- [Qemu-arm] [PULL 4/8] vl: constify VGAInterfaceInfo, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 3/8] hw/display/cirrus_vga: Remove unused include, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 8/8] i2c-ddc: move it to hw/display, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 2/8] hw/display/cirrus_vga: Update the documentation URL, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 7/8] ati-vga: Fix check for blt outside vram, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 5/8] vl: add -vga help support, Gerd Hoffmann, 2019/05/07
- [Qemu-arm] [PULL 6/8] qxl: avoid unaligned pointer reads/writes, Gerd Hoffmann, 2019/05/07
- Re: [Qemu-arm] [PULL 0/8] Vga 20190507 patches, Peter Maydell, 2019/05/07