Re: [Qemu-arm] [Qemu-devel] [PATCH for-QEMU-4.1 v5 18/29] hw/arm: Express dependencies of allwinner / cubieboard with Kconfig

[Philippe Mathieu-Daudé]

On 4/18/19 8:00 PM, Thomas Huth wrote:
> Add dependencies for the Cubitech Cubieboard.
> 
> Signed-off-by: Thomas Huth <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  default-configs/arm-softmmu.mak | 6 +-----
>  hw/arm/Kconfig                  | 9 +++++++++
>  2 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index c86a9f5427..a0b9016e3a 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -7,6 +7,7 @@ CONFIG_ARM_V7M=y
>  # CONFIG_TEST_DEVICES=n
>  
>  CONFIG_ARM_VIRT=y
> +CONFIG_CUBIEBOARD=y
>  CONFIG_EXYNOS4=y
>  CONFIG_HIGHBANK=y
>  CONFIG_INTEGRATOR=y
> @@ -32,7 +33,6 @@ CONFIG_NETDUINO2=y
>  
>  CONFIG_VGA=y
>  CONFIG_SSI_M25P80=y
> -CONFIG_ALLWINNER_EMAC=y
>  CONFIG_IMX_FEC=y
>  
>  CONFIG_FRAMEBUFFER=y
> @@ -60,10 +60,6 @@ CONFIG_IOTKIT_SYSINFO=y
>  CONFIG_ARMSSE_CPUID=y
>  CONFIG_ARMSSE_MHU=y
>  
> -CONFIG_ALLWINNER_A10_PIT=y
> -CONFIG_ALLWINNER_A10_PIC=y
> -CONFIG_ALLWINNER_A10=y
> -
>  CONFIG_FSL_IMX6=y
>  CONFIG_FSL_IMX25=y
>  CONFIG_FSL_IMX7=y
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 49306d6419..2ef5696900 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -25,6 +25,10 @@ config CHEETAH
>      select OMAP
>      select TSC210X
>  
> +config CUBIEBOARD
> +    bool
> +    select ALLWINNER_A10
> +
>  config DIGIC
>      bool
>      select PTIMER
> @@ -245,6 +249,11 @@ config ARM_V7M
>  
>  config ALLWINNER_A10
>      bool
> +    select AHCI
> +    select ALLWINNER_A10_PIT
> +    select ALLWINNER_A10_PIC
> +    select ALLWINNER_EMAC
> +    select SERIAL
>  
>  config RASPI
>      bool
>