[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 2/3] aspeed: add a per SoC mapping for the memory
|
From: |
Joel Stanley |
|
Subject: |
Re: [Qemu-arm] [PATCH 2/3] aspeed: add a per SoC mapping for the memory space |
|
Date: |
Fri, 12 Apr 2019 02:18:32 +0000 |
On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater <address@hidden> wrote:
>
> This will simplify the definition of new SoCs, like the AST2600 which
> should use a slightly different address space and have a different set
> of controllers.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> index 5bbd1fb87d18..9b601709e93c 100644
> --- a/hw/arm/aspeed_soc.c
> +++ b/hw/arm/aspeed_soc.c
> +static const hwaddr aspeed_soc_ast2400_memmap[] = {
> +static const hwaddr aspeed_soc_ast2500_memmap[] = {
Most of these arrays is common. And some of it will stay common in the
2600. Any ideas how we could avoid duplication?
This is fine for now.
Reviewed-by: Joel Stanley <address@hidden>