[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid v
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array |
|
Date: |
Fri, 29 Mar 2019 14:13:04 +0100 |
|
User-agent: |
NeoMutt/20180716 |
On Thu, Mar 28, 2019 at 03:26:35PM +0000, Peter Maydell wrote:
> In the stripe8() function we use a variable length array; however
> we know that the maximum length required is MAX_NUM_BUSSES. Use
> a fixed-length array and an assert instead.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/ssi/xilinx_spips.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
I really think is a good idea to remove variable length arrays!
Reviewed-by: Stefano Garzarella <address@hidden>
Thanks,
Stefano