[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v3] hw/arm/stellaris: Implement watchdog timer

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v3] hw/arm/stellaris: Implement watchdog timer
Date: Tue, 5 Mar 2019 13:58:09 +0000

On Mon, 4 Mar 2019 at 23:16, <address@hidden> wrote:
> From: Michel Heily <address@hidden>
> I've added the stellaris watchdog functionality because I needed it for a 
> home project.
> Documentation for the hardware can be found at 
> http://www.ti.com/lit/ds/symlink/lm3s6965.pdf.
> Signed-off-by: Michel Heily <address@hidden>

This patch looks good to me. I made a few minor tweaks:
 * rewrote the commit message to fit the way we normally
   describe changes
 * fixed a few minor nits found by scripts/checkpatch.pl
   (long lines, misplaced spaces, that kind of thing)
 * added a comment to the .c file with the docs URL

and I've applied it to my target-arm.next tree, so it should
get into master some time this week and will be in the
4.0 release.

Thanks for your contribution!

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]