[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper i
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function |
Date: |
Tue, 5 Feb 2019 00:11:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/4/19 8:35 PM, Thomas Huth wrote:
> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> As init helper in "hw/char/pl011.h"
>> ---
>> hw/net/smc91c111.c | 17 -----------------
>> include/hw/net/smc91c111.h | 25 ++++++++++++++++++++++++-
>> 2 files changed, 24 insertions(+), 18 deletions(-)
>
> Why? If you move code around like this, you should mention the reason in
> the patch description.
Oops this one wasn't supposed to be sent, I planned to drop it before
sending but probably forgot because it was late friday :/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-arm] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function,
Philippe Mathieu-Daudé <=