Re: [Qemu-arm] [PATCH 2/4] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

[Peter Maydell]

On Sun, 20 Jan 2019 at 14:35, Stefan Hajnoczi <address@hidden> wrote:
>
> From: Steffen Görtz <address@hidden>
>
> The nRF51 contains three regions of non-volatile memory (NVM):
> - CODE (R/W): contains code
> - FICR (R): Factory information like code size, chip id etc.
> - UICR (R/W): Changeable configuration data. Lock bits, Code
>   protection configuration, Bootloader address, Nordic SoftRadio
>   configuration, Firmware configuration.
>
> Read and write access to the memories is managed by the
> Non-volatile memory controller.
>
> Memory schema:
>  [ CPU ] -+- [ NVM, either FICR, UICR or CODE ]
>           |      |
>           \- [ NVMC ]
>
> Signed-off-by: Steffen Görtz <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  * Fix device-introspect-test segfault due to missing owner when
>    initializing FICR and UICR memory regions [Peter]
>  * Fix off-by-one assertion checks [Peter]
>  * Fix missing whitespace at end of comment [Peter]
>  * Clear UICR on reset - we'd need a block device for true
>    non-volatility [Peter]
>  * Use memory_region_flush_rom_device() to dirty/invalidate memory
>    [Peter]
> ---


Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM