qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 09/16] hw/devices: Move TI touchscreen declaration


From: Thomas Huth
Subject: Re: [Qemu-arm] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header
Date: Mon, 7 Jan 2019 08:22:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Since uWireSlave is only used in this new header, there is no
> need to expose it via "qemu/typedefs.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  MAINTAINERS                     |  2 ++
>  hw/arm/nseries.c                |  2 +-
>  hw/arm/palm.c                   |  2 +-
>  hw/input/tsc2005.c              |  2 +-
>  hw/input/tsc210x.c              |  4 ++--
>  include/hw/arm/omap.h           |  6 +-----
>  include/hw/devices.h            | 14 --------------
>  include/hw/input/ti_uwire_tsc.h | 28 ++++++++++++++++++++++++++++

I'd maybe rather name the new file "tsc2xxx.h" instead, so that it
resembles the names of the .c files. Just my 0.02 €.

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]