[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v4 01/16] hw/cpu: introduce CPU clust
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v4 01/16] hw/cpu: introduce CPU clusters |
Date: |
Thu, 8 Nov 2018 17:23:14 +0100 |
On Thu, Nov 8, 2018 at 5:17 PM Philippe Mathieu-Daudé <address@hidden> wrote:
> On 6/11/18 12:05, Luc Michel wrote:
> > This commit adds the cpu-cluster type. It aims at gathering CPUs from
> > the same cluster in a machine.
> >
> > For now it only has a `cluster-id` property.
> >
> > Signed-off-by: Luc Michel <address@hidden>
> > Reviewed-by: Alistair Francis <address@hidden>
> > ---
> > include/hw/cpu/cluster.h | 38 ++++++++++++++++++++++++++
> > hw/cpu/cluster.c | 59 ++++++++++++++++++++++++++++++++++++++++
Eduardo are you OK to cover these files in your "Machine core"
MAINTAINER's section?
> > hw/cpu/Makefile.objs | 2 +-
> > 3 files changed, 98 insertions(+), 1 deletion(-)
> > create mode 100644 include/hw/cpu/cluster.h
> > create mode 100644 hw/cpu/cluster.c
> >
> > diff --git a/include/hw/cpu/cluster.h b/include/hw/cpu/cluster.h
> > new file mode 100644
> > index 0000000000..0e5f121ec2
> > --- /dev/null
> > +++ b/include/hw/cpu/cluster.h
> > @@ -0,0 +1,38 @@
> > +/*
> > + * QEMU CPU cluster
> > + *
> > + * Copyright (c) 2018 GreenSocs SAS
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version 2
> > + * of the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, see
> > + * <http://www.gnu.org/licenses/gpl-2.0.html>
> > + */
> > +#ifndef HW_CPU_CLUSTER_H
> > +#define HW_CPU_CLUSTER_H
> > +
> > +#include "qemu/osdep.h"
> > +#include "hw/qdev.h"
> > +
> > +#define TYPE_CPU_CLUSTER "cpu-cluster"
> > +#define CPU_CLUSTER(obj) \
> > + OBJECT_CHECK(CPUClusterState, (obj), TYPE_CPU_CLUSTER)
> > +
> > +typedef struct CPUClusterState {
> > + /*< private >*/
> > + DeviceState parent_obj;
> > +
> > + /*< public >*/
> > + uint64_t cluster_id;
>
> As it or reducing this type:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> > +} CPUClusterState;
> > +
> > +#endif
> > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
> > new file mode 100644
> > index 0000000000..a23d55054a
> > --- /dev/null
> > +++ b/hw/cpu/cluster.c
> > @@ -0,0 +1,59 @@
> > +/*
> > + * QEMU CPU cluster
> > + *
> > + * Copyright (c) 2018 GreenSocs SAS
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version 2
> > + * of the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, see
> > + * <http://www.gnu.org/licenses/gpl-2.0.html>
> > + */
> > +
> > +#include "qemu/osdep.h"
> > +#include "hw/cpu/cluster.h"
> > +#include "qapi/error.h"
> > +#include "qemu/module.h"
> > +
> > +static void cpu_cluster_init(Object *obj)
> > +{
> > + static uint64_t cluster_id_auto_increment = 0;
> > + CPUClusterState *cluster = CPU_CLUSTER(obj);
> > +
> > + cluster->cluster_id = cluster_id_auto_increment++;
> > +}
> > +
> > +static Property cpu_cluster_properties[] = {
> > + DEFINE_PROP_UINT64("cluster-id", CPUClusterState, cluster_id, 0),
> > + DEFINE_PROP_END_OF_LIST()
> > +};
> > +
> > +static void cpu_cluster_class_init(ObjectClass *klass, void *data)
> > +{
> > + DeviceClass *dc = DEVICE_CLASS(klass);
> > +
> > + dc->props = cpu_cluster_properties;
> > +}
> > +
> > +static const TypeInfo cpu_cluster_type_info = {
> > + .name = TYPE_CPU_CLUSTER,
> > + .parent = TYPE_DEVICE,
> > + .instance_size = sizeof(CPUClusterState),
> > + .instance_init = cpu_cluster_init,
> > + .class_init = cpu_cluster_class_init,
> > +};
> > +
> > +static void cpu_cluster_register_types(void)
> > +{
> > + type_register_static(&cpu_cluster_type_info);
> > +}
> > +
> > +type_init(cpu_cluster_register_types)
> > diff --git a/hw/cpu/Makefile.objs b/hw/cpu/Makefile.objs
> > index cd52d20b65..8db9e8a7b3 100644
> > --- a/hw/cpu/Makefile.objs
> > +++ b/hw/cpu/Makefile.objs
> > @@ -1,5 +1,5 @@
> > obj-$(CONFIG_ARM11MPCORE) += arm11mpcore.o
> > obj-$(CONFIG_REALVIEW) += realview_mpcore.o
> > obj-$(CONFIG_A9MPCORE) += a9mpcore.o
> > obj-$(CONFIG_A15MPCORE) += a15mpcore.o
> > -common-obj-y += core.o
> > +common-obj-y += core.o cluster.o
> >
- [Qemu-arm] [PATCH v4 00/16] gdbstub: support for the multiprocess extension, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 05/16] gdbstub: add multiprocess support to vCont packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 09/16] gdbstub: add multiprocess support to gdb_vm_state_change(), Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 03/16] gdbstub: add multiprocess support to '?' packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 01/16] hw/cpu: introduce CPU clusters, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 02/16] gdbstub: introduce GDB processes, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 10/16] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 06/16] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 08/16] gdbstub: add multiprocess support to Xfer:features:read:, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 13/16] gdbstub: processes initialization on new peer connection, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 12/16] gdbstub: add support for vAttach packets, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 11/16] gdbstub: add support for extended mode packet, Luc Michel, 2018/11/06
- [Qemu-arm] [PATCH v4 15/16] gdbstub: add multiprocess extension support, Luc Michel, 2018/11/06