[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class |
Date: |
Wed, 19 Sep 2018 08:28:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 09/18/2018 08:40 PM, Peter Maydell wrote:
> On 31 August 2018 at 11:38, Cédric Le Goater <address@hidden> wrote:
>> The code looks better, it removes duplicated lines and it will ease
>> the introduction of common properties for the Aspeed machines.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
>> include/hw/arm/aspeed.h | 46 +++++++++
>> hw/arm/aspeed.c | 212 +++++++++++++---------------------------
>> 2 files changed, 116 insertions(+), 142 deletions(-)
>> create mode 100644 include/hw/arm/aspeed.h
>>
>> diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
>> new file mode 100644
>> index 000000000000..2b77f8d2b3c8
>> --- /dev/null
>> +++ b/include/hw/arm/aspeed.h
>> @@ -0,0 +1,46 @@
>> +/*
>> + * Aspeed Machines
>> + *
>> + * Copyright 2018 IBM Corp.
>> + *
>> + * This code is licensed under the GPL version 2 or later. See
>> + * the COPYING file in the top-level directory.
>> + */
>> +#ifndef _ARM_ASPEED_H
>> +#define _ARM_ASPEED_H
>
> Leading underscore followed by capital is a C reserved
> identifier. This should just be ARM_ASPEED_H.
Ah yes. I will fix that.
Thanks,
C.
> Patch looks good otherwise.
>
> thanks
> --- PMM
>