[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] hw/misc/bcm2835_fb: Move config
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] hw/misc/bcm2835_fb: Move config fields to their own struct |
Date: |
Thu, 23 Aug 2018 21:31:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/14/2018 07:44 AM, Peter Maydell wrote:
> The handling of framebuffer properties in the bcm2835_property code
> is a bit clumsy, because for each of the many fb related properties
> we try to track the value we're about to set and whether we're going
> to be setting a value, and then we hand all the new values off
> to the framebuffer via a function which takes them all as separate
> arguments. It would be simpler if the property code could easily
> copy all the framebuffer's current settings, update them with
> the new specified values and then ask the framebuffer to switch
> to the new set.
>
> As the first part of this refactoring, pull all the fb config
> settings fields in BCM2835FBState out into their own struct.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/display/bcm2835_fb.h | 26 ++++++--
> hw/display/bcm2835_fb.c | 114 +++++++++++++++++---------------
> hw/misc/bcm2835_property.c | 28 ++++----
> 3 files changed, 94 insertions(+), 74 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 0/8] arm/raspi: Make fb handle virtual viewport, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 3/8] hw/display/bcm2835_fb: Drop unused size and pitch fields, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 2/8] hw/misc/bcm2835_property: Track fb settings using BCM2835FBConfig, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 4/8] hw/display/bcm2835_fb: Reset resolution, etc correctly, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 5/8] hw/display/bcm2835_fb: Abstract out calculation of pitch, size, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 1/8] hw/misc/bcm2835_fb: Move config fields to their own struct, Peter Maydell, 2018/08/14
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] hw/misc/bcm2835_fb: Move config fields to their own struct,
Richard Henderson <=
- [Qemu-arm] [PATCH 7/8] hw/display/bcm2835_fb: Validate config settings, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 6/8] hw/display/bcm2835_fb: Fix handling of virtual framebuffer, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 8/8] hw/display/bcm2835_fb: Validate bcm2835_fb_mbox_push() config, Peter Maydell, 2018/08/14
- Re: [Qemu-arm] [PATCH 0/8] arm/raspi: Make fb handle virtual viewport, Peter Maydell, 2018/08/23