Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/mps2: Fix ID register errors on AN511 and AN385

[Richard Henderson]

On 08/23/2018 10:52 AM, Peter Maydell wrote:
> Fix MPS2 SCC config register values for the mps2-an511
> and mps2-an385 boards:
>  * the SCC_AID bits [23:20] specify the FPGA build target board revision,
>    and the SCC_CFG4 register specifies the actual board revision, so
>    these should have matching values. Claim to be board revision C,
>    consistently -- we had the revision in the wrong part of SCC_AID.
>  * SCC_ID bits [15:4] should be the board number in hex, not decimal
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This fixes a bug that I noticed for the AN505 model and fixed there,
> but forgot to also fix on our other MPS image models.
> 
>  hw/arm/mps2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~