[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask
From: |
Thomas Huth |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf |
Date: |
Fri, 22 Jun 2018 10:34:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/arm/omap.h | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
[...]
> @@ -997,14 +998,17 @@ enum {
>
> # ifdef TCMI_VERBOSE
> # define OMAP_8B_REG(paddr) \
> - fprintf(stderr, "%s: 8-bit register " OMAP_FMT_plx "\n", \
> - __func__, paddr)
> + qemu_log_mask(LOG_GUEST_ERROR, \
> + "%s: 8-bit register " OMAP_FMT_plx "\n", \
> + __func__, paddr)
> # define OMAP_16B_REG(paddr) \
> - fprintf(stderr, "%s: 16-bit register " OMAP_FMT_plx "\n", \
> - __func__, paddr)
> + qemu_log_mask(LOG_GUEST_ERROR, \
> + "%s: 16-bit register " OMAP_FMT_plx "\n", \
> + __func__, paddr)
> # define OMAP_32B_REG(paddr) \
> - fprintf(stderr, "%s: 32-bit register " OMAP_FMT_plx "\n", \
> - __func__, paddr)
> + qemu_log_mask(LOG_GUEST_ERROR, \
> + "%s: 32-bit register " OMAP_FMT_plx "\n", \
> + __func__, paddr)
> # else
> # define OMAP_8B_REG(paddr)
> # define OMAP_16B_REG(paddr)
>
Since the qemu_log_mask(LOG_GUEST_ERROR, ...) calls are not shown up by
default anymore, I think it would rather be better to get rid of this
#ifdef TCMI_VERBOSE ... #endif block now and put the qemu_log_mask()
statements directly into the omap_badwidth_* functions instead.
Thomas
- [Qemu-arm] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, (continued)
- [Qemu-arm] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 07/11] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 10/11] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 09/11] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-arm] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/21
- Re: [Qemu-arm] [Qemu-devel] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf,
Thomas Huth <=
- [Qemu-arm] [PATCH 11/11] hw/net/smc91c111: Use qemu_log_mask(GUEST_ERROR) instead of hw_error, Philippe Mathieu-Daudé, 2018/06/21