Re: [Qemu-arm] [PATCH v2 1/4] hw/arm/smmuv3: Fix translate error handling

[Peter Maydell]

On 12 June 2018 at 09:08, Eric Auger <address@hidden> wrote:
> From: Jia He <address@hidden>
>
> In case the STE's config is "Bypass" we currently don't set the
> IOMMUTLBEntry perm flags and the access does not succeed. Also
> if the config is 0b0xx (Aborted/Reserved), decode_ste and
> smmuv3_decode_config currently returns -EINVAL and we don't enter
> the expected code path: we record an event whereas we should not.
>
> This patch fixes those bugs and simplifies the error handling.
> decode_ste and smmuv3_decode_config now return 0 if aborted or
> bypassed config was found. Only bad config info produces negative
> error values. In smmuv3_translate we more clearly differentiate
> errors, bypass/smmu disabled, aborted and success cases. Also
> trace points are differentiated.
>
> Fixes: 9bde7f0674fe ("hw/arm/smmuv3: Implement translate callback")
> Reported-by: address@hidden
> Signed-off-by: address@hidden
> Signed-off-by: Eric Auger <address@hidden>
>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM