[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/8] hw/sd/ssi-sd: Force cards connec
From: |
Alistair Francis |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10 |
Date: |
Mon, 4 Jun 2018 11:26:05 -0700 |
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Can you add a justification for this in the commit message?
Alistair
> ---
> hw/sd/ssi-sd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c
> index ae04b6641b..c62fdc871c 100644
> --- a/hw/sd/ssi-sd.c
> +++ b/hw/sd/ssi-sd.c
> @@ -253,6 +253,8 @@ static void ssi_sd_realize(SSISlave *d, Error **errp)
> /* FIXME use a qdev drive property instead of drive_get_next() */
> dinfo = drive_get_next(IF_SD);
> carddev = qdev_create(&s->sdbus.qbus, TYPE_SD_CARD);
> + object_property_set_uint(OBJECT(carddev),
> + SD_PHY_SPECv1_10_VERS, "spec_version", &err);
> if (dinfo) {
> qdev_prop_set_drive(carddev, "drive", blk_by_legacy_dinfo(dinfo),
> &err);
> }
> --
> 2.17.1
>
>
- Re: [Qemu-arm] [PATCH 1/8] sdcard: Update the Configuration Register (SCR) to Spec Version 1.10, (continued)
[Qemu-arm] [PATCH 2/8] sdcard: Allow commands valid in SPI mode, Philippe Mathieu-Daudé, 2018/06/02
[Qemu-arm] [PATCH 3/8] sdcard: Add a 'spec_version' property, Philippe Mathieu-Daudé, 2018/06/02
[Qemu-arm] [PATCH 4/8] sdcard: Set Spec v2.00 as default, Philippe Mathieu-Daudé, 2018/06/02
[Qemu-arm] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10, Philippe Mathieu-Daudé, 2018/06/02
- Re: [Qemu-arm] [Qemu-devel] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10,
Alistair Francis <=
[Qemu-arm] [PATCH 7/8] sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR), Philippe Mathieu-Daudé, 2018/06/02
[Qemu-arm] [PATCH 6/8] sdcard: Disable SEND_IF_COND (CMD8) for Spec v1, Philippe Mathieu-Daudé, 2018/06/02
[Qemu-arm] [PATCH 8/8] sdcard: Disable CMD19/CMD23 for Spec v2, Philippe Mathieu-Daudé, 2018/06/02
Re: [Qemu-arm] [Qemu-devel] [PATCH 0/8] sdcard: cleanup the SD_SPEC version, Alistair Francis, 2018/06/04