[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 1/5] fpu/softfloat: int_to_float ensure r fully
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v3 1/5] fpu/softfloat: int_to_float ensure r fully initialised |
Date: |
Thu, 10 May 2018 13:40:55 +0100 |
On 10 May 2018 at 10:42, Alex Bennée <address@hidden> wrote:
> Reported by Coverity (CID1390635). We ensure this for uint_to_float
> later on so we might as well mirror that.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> fpu/softfloat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 70e0c40a1c..3adf6a06e4 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1517,7 +1517,7 @@ FLOAT_TO_UINT(64, 64)
>
> static FloatParts int_to_float(int64_t a, float_status *status)
> {
> - FloatParts r;
> + FloatParts r = {};
> if (a == 0) {
> r.cls = float_class_zero;
> r.sign = false;
> --
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-arm] [PATCH v3 0/5] refactor float-to-float and fix AHP, Alex Bennée, 2018/05/10
- [Qemu-arm] [PATCH v3 1/5] fpu/softfloat: int_to_float ensure r fully initialised, Alex Bennée, 2018/05/10
- [Qemu-arm] [PATCH v3 5/5] target/arm: squash FZ16 behaviour for conversions, Alex Bennée, 2018/05/10
- [Qemu-arm] [PATCH v3 4/5] target/arm: convert conversion helpers to fpst/ahp_flag, Alex Bennée, 2018/05/10
- [Qemu-arm] [PATCH v3 3/5] fpu/softfloat: support ARM Alternative half-precision, Alex Bennée, 2018/05/10
- [Qemu-arm] [PATCH v3 2/5] fpu/softfloat: re-factor float to float conversions, Alex Bennée, 2018/05/10
- Re: [Qemu-arm] [PATCH v3 0/5] refactor float-to-float and fix AHP, Peter Maydell, 2018/05/10