[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 0/2] target/arm: Coverity fixups
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH 0/2] target/arm: Coverity fixups |
|
Date: |
Thu, 3 May 2018 16:05:06 +0100 |
On 1 May 2018 at 19:04, Richard Henderson <address@hidden> wrote:
> The first patch covers four related false positives. However,
> we check the same condition twice and we certainly don't need
> to that. Plus the assert might just help documentation-wise.
>
> The second patch covers dead code. I believe that Coverity is
> right and that there are no paths that have !is_q at this point.
> Add the assert to check that is true.
>
> The RISU tests that I ran over these insns came out clean.
>
Applied to target-arm.next, thanks.
-- PMM