qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 2/3] hw/arm/aspeed: don't make 'boot_rom' region '


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 2/3] hw/arm/aspeed: don't make 'boot_rom' region 'nomigrate'
Date: Sat, 21 Apr 2018 10:34:07 +0100

On 21 April 2018 at 10:07, Cédric Le Goater <address@hidden> wrote:
> On 04/20/2018 02:48 PM, Peter Maydell wrote:
>> Currently we use memory_region_init_ram_nomigrate() to create
>> the "aspeed.boot_rom" memory region, and we don't manually
>> register it with vmstate_register_ram(). This currently
>> means that its contents are migrated but as a ram block
>> whose name is the empty string; in future it may mean they
>> are not migrated at all. Use memory_region_init_ram() instead.
>>
>> Note that this is a cross-version migration compatibility break
>> for the "palmetto-bmc", "ast2500-evb" and "romulus-bmc" machines.
>
> Migration does not work for these.

Well, at least we're not breaking anything :-)
Do you know why migration doesn't work?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]