[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 04/67] target/arm: Implement SVE Bitwise Logica
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [PATCH v2 04/67] target/arm: Implement SVE Bitwise Logical - Unpredicated Group |
Date: |
Thu, 22 Feb 2018 11:28:52 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/22/2018 10:04 AM, Peter Maydell wrote:
> On 17 February 2018 at 18:22, Richard Henderson
> <address@hidden> wrote:
>> These were the instructions that were stubbed out when
>> introducing the decode skeleton.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> target/arm/translate-sve.c | 50
>> +++++++++++++++++++++++++++++++++++++++-------
>> 1 file changed, 43 insertions(+), 7 deletions(-)
>>
>> diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
>> index 2c9e4733cb..50cf2a1fdd 100644
>> --- a/target/arm/translate-sve.c
>> +++ b/target/arm/translate-sve.c
>> @@ -32,6 +32,10 @@
>> #include "trace-tcg.h"
>> #include "translate-a64.h"
>>
>> +typedef void GVecGen2Fn(unsigned, uint32_t, uint32_t, uint32_t, uint32_t);
>> +typedef void GVecGen3Fn(unsigned, uint32_t, uint32_t,
>> + uint32_t, uint32_t, uint32_t);
>
> I see we already have these in translate-a64.c -- put them in
> translate-a64.h ?
Good plan, thanks.
r~
- [Qemu-arm] [PATCH v2 00/67] target/arm: Scalable Vector Extension, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 01/67] target/arm: Enable SVE for aarch64-linux-user, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 02/67] target/arm: Introduce translate-a64.h, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 03/67] target/arm: Add SVE decode skeleton, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 04/67] target/arm: Implement SVE Bitwise Logical - Unpredicated Group, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 06/67] target/arm: Implement SVE predicate test, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 07/67] target/arm: Implement SVE Predicate Logical Operations Group, Richard Henderson, 2018/02/17
- [Qemu-arm] [PATCH v2 08/67] target/arm: Implement SVE Predicate Misc Group, Richard Henderson, 2018/02/17