[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v4 09/14] pci: Add support for Designware IP block
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v4 09/14] pci: Add support for Designware IP block |
Date: |
Tue, 16 Jan 2018 14:34:42 +0000 |
On 16 January 2018 at 01:37, Andrey Smirnov <address@hidden> wrote:
> Add code needed to get a functional PCI subsytem when using in
> conjunction with upstream Linux guest (4.13+). Tested to work against
> "e1000e" (network adapter, using MSI interrupts) as well as
> "usb-ehci" (USB controller, using legacy PCI interrupts).
>
> Cc: Peter Maydell <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Signed-off-by: Andrey Smirnov <address@hidden>
> ---
> default-configs/arm-softmmu.mak | 2 +
> hw/pci-host/Makefile.objs | 2 +
> hw/pci-host/designware.c | 618
> +++++++++++++++++++++++++++++++++++++++
> include/hw/pci-host/designware.h | 93 ++++++
> include/hw/pci/pci_ids.h | 2 +
> 5 files changed, 717 insertions(+)
> create mode 100644 hw/pci-host/designware.c
> create mode 100644 include/hw/pci-host/designware.h
I'm not familiar enough with our PCI code to be able to review
this, I'm afraid. MST and Marcel are our PCI subsystem maintainers --
could one of you have a look at whether this seems to be a correct
implementation of a pcie host controller ?
I did notice it seems to be missing device state save/load support.
thanks
-- PMM
Re: [Qemu-arm] [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block, Marcel Apfelbaum, 2018/01/30
[Qemu-arm] [PATCH v4 13/14] hw/arm: Move virt's PSCI DT fixup code to arm/boot.c, Andrey Smirnov, 2018/01/15