[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 01/11] imx_fec: Do not link to netdev
From: |
Andrey Smirnov |
Subject: |
[Qemu-arm] [PATCH v3 01/11] imx_fec: Do not link to netdev |
Date: |
Tue, 2 Jan 2018 11:36:12 -0800 |
Binding to a particular netdev doesn't seem to belong to this layer
and should probably be done as a part of board or SoC specific code.
Convert all of the users of this IP block to use
qdev_set_nic_properties() instead.
Cc: Peter Maydell <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: Philippe Mathieu-Daudé <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Andrey Smirnov <address@hidden>
---
hw/arm/fsl-imx6.c | 1 +
hw/net/imx_fec.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index 59ef33efa9..b0d4088290 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -385,6 +385,7 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp)
spi_table[i].irq));
}
+ qdev_set_nic_properties(DEVICE(&s->eth), &nd_table[0]);
object_property_set_bool(OBJECT(&s->eth), true, "realized", &err);
if (err) {
error_propagate(errp, err);
diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index 90e6ee35ba..88b4b049d7 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -1171,8 +1171,6 @@ static void imx_eth_realize(DeviceState *dev, Error
**errp)
qemu_macaddr_default_if_unset(&s->conf.macaddr);
- s->conf.peers.ncs[0] = nd_table[0].netdev;
-
s->nic = qemu_new_nic(&imx_eth_net_info, &s->conf,
object_get_typename(OBJECT(dev)),
DEVICE(dev)->id, s);
--
2.14.3
- [Qemu-arm] [PATCH v3 00/11] i.MX FEC changes, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 02/11] imx_fec: Refactor imx_eth_enable_rx(), Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 01/11] imx_fec: Do not link to netdev,
Andrey Smirnov <=
- [Qemu-arm] [PATCH v3 03/11] imx_fec: Change queue flushing heuristics, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 04/11] imx_fec: Move Tx frame buffer away from the stack, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 05/11] imx_fec: Use ENET_FTRL to determine truncation length, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 07/11] imx_fec: Emulate SHIFT16 in ENETx_RACC, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 06/11] imx_fec: Use MIN instead of explicit ternary operator, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 08/11] imx_fec: Add support for multiple Tx DMA rings, Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 10/11] imx_fec: Fix a typo in imx_enet_receive(), Andrey Smirnov, 2018/01/02
- [Qemu-arm] [PATCH v3 11/11] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file, Andrey Smirnov, 2018/01/02