[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] BCM2837 and machine raspi3
|
From: |
Andrew Baumann |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] BCM2837 and machine raspi3 |
|
Date: |
Tue, 28 Nov 2017 17:54:01 +0000 |
> From: bzt bzt [mailto:address@hidden
> Sent: Tuesday, 28 November 2017 03:27
> Yes, I agree. I've provided a parameterised version on Oct 24, which does not
> have a separate bcm2837 implementation. Is that patch ok?
That patch was moving in the right direction, but I think there were two
problems with it. First, the right way to pass a parameter is via a property
field (as Peter explained). Second, IMO the parameter should be the CPU model
string to instantiate and not the Pi version number.
> Or should I wait
> for Alistair's patch (https://lists.gnu.org/archive/html/qemu-devel/2017-
> 10/msg04153.html)?
Alistair's patch doesn't actually help you as far as I can see, since it
doesn't change what CPU bcm2836 instantiates. I think it just means that if the
user specifies a different CPU type they get an error rather than being
silently ignored.
Andrew