[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH for-2.11] target/arm: Report GICv3 sy
From: |
Alistair Francis |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH for-2.11] target/arm: Report GICv3 sysregs present in ID registers if needed |
Date: |
Thu, 16 Nov 2017 09:03:15 -0800 |
On Wed, Nov 15, 2017 at 3:57 AM, Peter Maydell <address@hidden> wrote:
> On 15 November 2017 at 01:14, Alistair Francis <address@hidden> wrote:
>> On Tue, Nov 7, 2017 at 7:01 AM, Peter Maydell <address@hidden> wrote:
>>> The CPU ID registers ID_AA64PFR0_EL1, ID_PFR1_EL1 and ID_PFR1
>>> have a field for reporting presence of GICv3 system registers.
>>> We need to report this field correctly in order for Xen to
>>> work as a guest inside QEMU emulation. We mustn't incorrectly
>>> claim the sysregs exist when they don't, though, or Linux will
>>> crash.
>>>
>>> Unfortunately the way we've designed the GICv3 emulation in QEMU
>>> puts the system registers as part of the GICv3 device, which
>>> may be created after the CPU proper has been realized. This
>>> means that we don't know at the point when we define the ID
>>> registers what the correct value is. Handle this by switching
>>> them to calling a function at runtime to read the value, where
>>> we can fill in the GIC field appropriately.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>
>> Is this going to make it into 2.11?
>
> Yes, it's supposed to go into 2.11 -- I think I just forgot
> to put it in the rc1 pullreq, but it'll go in rc2.
Great! Thanks Peter
Alistair
>
> thanks
> -- PMM