[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 1/8] aspeed: use a ROM memory region to catch i
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH v5 1/8] aspeed: use a ROM memory region to catch invalid writes |
Date: |
Fri, 20 Oct 2017 08:30:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/20/2017 05:10 AM, Philippe Mathieu-Daudé wrote:
> On 10/19/2017 12:44 PM, Peter Maydell wrote:
>> On 19 October 2017 at 16:12, Cédric Le Goater <address@hidden> wrote:
>>> Some legacy firmwares access unimplemented addresses on the Aspeed SoC
>>> (old U-Boot code using variables in the bss when it shouldn't do).
>>> Let's use a ROM memory region to catch the invalid writes and support
>>> new boards without using the 'ignore_memory_transaction_failures'
>>> flag.
>>>
>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>> ---
>>>
>>> Changes since v4 :
>>>
>>> - use a ROM memory region
>>
>> Probably worth mentioning in the commit message that this
>> is a migration compatibility break for these boards.
>
> What about the eeprom_buf from patch 6 "Add EEPROM I2C devices"?
>
> My understanding is a migrated board would resume with a zeroized
> eeprom, is this the expected behaviour?
That would be probably the case. yes. As we don't populate the eeprom
with VPD at machine init time and that migration is clearly not tested,
I think we will address this issue later.
Thanks,
C.
- [Qemu-arm] [PATCH v5 0/8] aspeed: add a witherspoon-bmc machine, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 2/8] aspeed: remove ignore_memory_transaction_failures all boards, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 3/8] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 4/8] aspeed: add an I2C RTC device to all machines, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 5/8] smbus: add a smbus_eeprom_init_one() routine, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 6/8] aspeed: Add EEPROM I2C devices, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 7/8] misc: add pca9552 LED blinker model, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v5 8/8] aspeed: add the pc9552 chips to the witherspoon machine, Cédric Le Goater, 2017/10/19