qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH] nvic: Add missing 'break'


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-arm] [PATCH] nvic: Add missing 'break'
Date: Wed, 11 Oct 2017 16:31:39 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 10/11/2017 02:24 PM, Peter Maydell wrote:
> Coverity points out that we forgot the 'break' for
> the SAU_CTRL write case (CID1381683). This has
> no actual visible consequences because it happens
> that the following case is effectively a no-op.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/intc/armv7m_nvic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index 201e90f..be46639 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -1447,6 +1447,7 @@ static void nvic_writel(NVICState *s, uint32_t offset, 
> uint32_t value,
>              return;
>          }
>          cpu->env.sau.ctrl = value & 3;
> +        break;
>      case 0xdd4: /* SAU_TYPE */
>          if (!arm_feature(&cpu->env, ARM_FEATURE_V8)) {
>              goto bad_offset;
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]