Re: [Qemu-arm] [Qemu-devel] [PATCH] bcm2835_armtimer: add bcm2835 ARM timer

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] bcm2835_armtimer: add bcm2835 ARM timer

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fd596b541c bcm2835_armtimer: add bcm2835 ARM timer

=== OUTPUT BEGIN ===
Checking PATCH 1/1: bcm2835_armtimer: add bcm2835 ARM timer...
ERROR: space prohibited before open square bracket '['
#147: FILE: hw/timer/bcm2835_armtimer.c:73:
+static const uint16_t ctrl_prescale [] = { 1, 16, 256, 1 };

ERROR: return is not a function, parentheses are not required
#195: FILE: hw/timer/bcm2835_armtimer.c:121:
+        return (s->raw_irq && (s->ctrl & CTRL_INT_ENABLE));

ERROR: braces {} are necessary for all arms of this statement
#220: FILE: hw/timer/bcm2835_armtimer.c:146:
+        if (s->ctrl & CTRL_TIMER_ENABLE)
[...]

ERROR: braces {} are necessary for all arms of this statement
#234: FILE: hw/timer/bcm2835_armtimer.c:160:
+        if (s->ctrl & CTRL_TIMER_ENABLE)
[...]

total: 4 errors, 0 warnings, 364 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden