[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 19/19] nvic: Support banked exception
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete |
Date: |
Wed, 20 Sep 2017 13:39:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/12/2017 01:14 PM, Peter Maydell wrote:
> Update armv7m_nvic_acknowledge_irq() and armv7m_nvic_complete_irq()
> to handle banked exceptions:
> * acknowledge needs to use the correct vector, which may be
> in sec_vectors[]
> * acknowledge needs to return to its caller whether the
> exception should be taken to secure or non-secure state
> * complete needs its caller to tell it whether the exception
> being completed is a secure one or not
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/cpu.h | 15 +++++++++++++--
> hw/intc/armv7m_nvic.c | 26 ++++++++++++++++++++------
> target/arm/helper.c | 8 +++++---
> hw/intc/trace-events | 4 ++--
> 4 files changed, 40 insertions(+), 13 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 13/19] nvic: Implement v8M changes to fixed priority exceptions, (continued)
- [Qemu-arm] [PATCH 18/19] nvic: Make SHCSR banked for v8M, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 11/19] nvic: Compare group priority for escalation to HF, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 08/19] nvic: Handle banked exceptions in nvic_recompute_state(), Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 14/19] nvic: Disable the non-secure HardFault if AIRCR.BFHFNMINS is clear, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete, Peter Maydell, 2017/09/12
- Re: [Qemu-arm] [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete,
Richard Henderson <=
- [Qemu-arm] [PATCH 16/19] target/arm: Handle banking in negative-execution-priority check in cpu_mmu_index(), Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 17/19] nvic: Make ICSR banked for v8M, Peter Maydell, 2017/09/12
- Re: [Qemu-arm] [Qemu-devel] [PATCH 00/19] ARMv8M: support security extn in the NVIC, no-reply, 2017/09/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH 00/19] ARMv8M: support security extn in the NVIC, no-reply, 2017/09/19