[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 07/15] target/arm: Fix outdated comme
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 07/15] target/arm: Fix outdated comment about exception exit |
Date: |
Thu, 3 Aug 2017 17:25:40 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Aug 02, 2017 at 05:43:53PM +0100, Peter Maydell wrote:
> When we switched our handling of exception exit to detect
> the magic addresses at translate time rather than via
> a do_unassigned_access hook, we forgot to update a
> comment; correct the omission.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index fd83a21..cb88c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -6143,7 +6143,7 @@ static void do_v7m_exception_exit(ARMCPU *cpu)
> bool rettobase = false;
>
> /* We can only get here from an EXCP_EXCEPTION_EXIT, and
> - * arm_v7m_do_unassigned_access() enforces the architectural rule
> + * gen_bx_excret() enforces the architectural rule
> * that jumps to magic addresses don't have magic behaviour unless
> * we're in Handler mode (compare pseudocode BXWritePC()).
> */
> --
> 2.7.4
>
>
- Re: [Qemu-arm] [Qemu-devel] [PATCH 09/15] target/arm: Don't store M profile PRIMASK and FAULTMASK in daif, (continued)
- [Qemu-arm] [PATCH 06/15] target/arm: Remove incorrect comment about MPU_CTRL, Peter Maydell, 2017/08/02
- [Qemu-arm] [PATCH 10/15] target/arm: Don't use cpsr_write/cpsr_read to transfer M profile XPSR, Peter Maydell, 2017/08/02
- [Qemu-arm] [PATCH 07/15] target/arm: Fix outdated comment about exception exit, Peter Maydell, 2017/08/02
- [Qemu-arm] [PATCH 08/15] target/arm: Define and use XPSR bit masks, Peter Maydell, 2017/08/02
- [Qemu-arm] [PATCH 05/15] hw/intc/armv7m_nvic.c: Remove out of date comment, Peter Maydell, 2017/08/02
- [Qemu-arm] [PATCH 04/15] target/arm: Tighten up Thumb decode where new v8M insns will be, Peter Maydell, 2017/08/02