[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH for 2.10 22/35] arm/vexpress: fix potential memory lea
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-arm] [PATCH for 2.10 22/35] arm/vexpress: fix potential memory leak |
Date: |
Mon, 24 Jul 2017 15:27:38 -0300 |
Reorder to only allocate if required.
hw/arm/vexpress.c:667:13: warning: Potential leak of memory pointed to by
'flashalias'
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/arm/vexpress.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index 528c65ddb6..76c4d84482 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -553,8 +553,6 @@ static void vexpress_common_init(MachineState *machine)
MemoryRegion *sysmem = get_system_memory();
MemoryRegion *vram = g_new(MemoryRegion, 1);
MemoryRegion *sram = g_new(MemoryRegion, 1);
- MemoryRegion *flashalias = g_new(MemoryRegion, 1);
- MemoryRegion *flash0mem;
const hwaddr *map = daughterboard->motherboard_map;
int i;
@@ -657,6 +655,9 @@ static void vexpress_common_init(MachineState *machine)
}
if (map[VE_NORFLASHALIAS] != -1) {
+ MemoryRegion *flashalias = g_new(MemoryRegion, 1);
+ MemoryRegion *flash0mem;
+
/* Map flash 0 as an alias into low memory */
flash0mem = sysbus_mmio_get_region(SYS_BUS_DEVICE(pflash0), 0);
memory_region_init_alias(flashalias, NULL, "vexpress.flashalias",
--
2.13.3
- [Qemu-arm] [PATCH for 2.10 22/35] arm/vexpress: fix potential memory leak,
Philippe Mathieu-Daudé <=