qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v3 4/6] target/arm/translate: ensure gen_goto_tb s


From: Richard Henderson
Subject: Re: [Qemu-arm] [PATCH v3 4/6] target/arm/translate: ensure gen_goto_tb sets exit flags
Date: Tue, 11 Jul 2017 08:16:12 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/11/2017 07:59 AM, Alex Bennée wrote:
      if (use_goto_tb(s, dest)) {
          tcg_gen_goto_tb(n);
          gen_set_pc_im(s, dest);
          tcg_gen_exit_tb((uintptr_t)s->tb + n);
+        s->is_jmp = DISAS_TB_JUMP;
      } else {
          gen_set_pc_im(s, dest);
          gen_goto_ptr();
+        s->is_jmp = DISAS_JUMP;
      }

I think DISAS_TB_JUMP is appropriate for both cases. When not using goto_tb, the jump is still static and we still chain to the next TB via goto_ptr.

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]